1u0 commented on a change in pull request #8741: [FLINK-12752] Add Option to
Pass Seed for JobID Hash for StandaloneJobClusterEntrypoint
URL: https://github.com/apache/flink/pull/8741#discussion_r298962994
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfigurationParserFactory.java
##########
@@ -92,9 +105,23 @@ public StandaloneJobClusterConfiguration
createResult(@Nonnull CommandLine comma
restPort,
savepointRestoreSettings,
jobId,
+ jobIdSeed,
jobClassName);
}
+ private String getJobIdSeed(@Nonnull final CommandLine commandLine)
throws FlinkParseException {
+
+ boolean isJobIdSeedConfigured =
commandLine.hasOption(JOB_ID_SEED_OPTION.getOpt());
+ boolean isJobIdConfigured =
commandLine.hasOption(JOB_ID_OPTION.getOpt());
+
+ if (isJobIdSeedConfigured && isJobIdConfigured) {
Review comment:
Personally, I'd prefer to be the templates more neutral. They may have
`--job-id-seed` by default, provided that it's not mutually exclusive with
`--job-id` option. So if both options are present, the system would pick the
`--job-id` by priority (as it was originally described in the ticket). But that
just my own preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
