[ 
https://issues.apache.org/jira/browse/FLINK-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14875644#comment-14875644
 ] 

ASF GitHub Bot commented on FLINK-2694:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1145

    [FLINK-2694] [test-stability] Hardens the 
JobManagerProcessReapingTest.testReapProcessOnFailure test case

    The `JobManagerProcessReapingTest.testReapProcessOnFailure` predetermines 
the port for the `JobManager` which is started by using 
`NetUtils.getAvailablePort`. This can cause problems if in the meantime another 
process has opened a socket binding to this port. In order to harden this test 
case, the `JobManager` is now allowed to pick itself a free port. The selected 
port is extracted from the logging output of the `JobManager`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink 
fixJobManagerProcessReapingTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1145
    
----
commit 4332b8e8aafd43f766be5357e505297322d109c7
Author: Till Rohrmann <[email protected]>
Date:   2015-09-18T13:49:24Z

    [FLINK-2694] [test-stability] Hardens the 
JobManagerProcessReapingTest.testReapProcessOnFailure test case by letting the 
JobManager choose its port instead of predetermining it via the 
NetUtils.getAvailablePort.

----


> JobManagerProcessReapingTest.testReapProcessOnFailure failed on Travis
> ----------------------------------------------------------------------
>
>                 Key: FLINK-2694
>                 URL: https://issues.apache.org/jira/browse/FLINK-2694
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Till Rohrmann
>            Priority: Critical
>              Labels: test-stability
>
> I observed a failing 
> {{JobManagerProcessReapingTest.testReapProcessOnFailure}} test case on 
> Travis. The reason for the test failure seems to be that the {{JobManager}} 
> could not be started. The reason for this was that Netty could not bind to 
> the specified port.
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/80642036/log.txt



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to