JingsongLi commented on a change in pull request #8977:
[FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner
support add kinds of QueryOperations.
URL: https://github.com/apache/flink/pull/8977#discussion_r300215015
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/expressions/RexNodeConverter.java
##########
@@ -79,25 +112,196 @@
private final RelBuilder relBuilder;
Review comment:
> TODO actually we should use {@link ResolvedExpressionVisitor} here as it
is the output of the API
You can comment clear, why it keep `ExpressionVisitor` instead of
`ResolvedExpressionVisitor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
