wuchong commented on a change in pull request #8937: [FLINK-13040] promote
blink table config and add to document
URL: https://github.com/apache/flink/pull/8937#discussion_r300215876
##########
File path:
flink-annotations/src/main/java/org/apache/flink/annotation/docs/Documentation.java
##########
@@ -59,6 +59,27 @@
int position() default Integer.MAX_VALUE;
}
+ /**
+ * Annotation used on table config to introduce additional
table-related meta data.
+ *
+ * <p>The {@link TableMeta#execMode()} argument indicates which exec
mode the config works for,
+ * for batch, streaming or both.
+ *
+ */
+ @Target(ElementType.FIELD)
+ @Retention(RetentionPolicy.RUNTIME)
+ @Internal
+ public @interface TableMeta {
+ ExecMode execMode();
+ }
+
+ /**
+ * Which exec mode the config works for.
+ */
+ public enum ExecMode {
+ BATCH, STREAMING, BOTH
Review comment:
What about renaming `BOTH` to `BATCH_STREAMING` to explicitly statement it
works for both batch and streaming and more align with the generated tags. Just
`BOTH` doesn't know what's BOTH.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
