xintongsong commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r300304006
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -358,14 +384,14 @@ private static MemoryManager createMemoryManager(
float memoryFraction =
taskManagerServicesConfiguration.getMemoryFraction();
if (memType == MemoryType.HEAP) {
- long freeHeapMemoryWithDefrag =
taskManagerServicesConfiguration.getFreeHeapMemoryWithDefrag();
- // network buffers allocated off-heap -> use
memoryFraction of the available heap:
- long relativeMemSize = (long)
(freeHeapMemoryWithDefrag * memoryFraction);
+ long maxJvmHeapMemory =
taskManagerServicesConfiguration.getMaxJvmHeapMemory();
Review comment:
As we discussed offline, I reverted this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
