danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300519348
########## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java ########## @@ -355,9 +424,12 @@ * } * </pre> * + * @deprecated Use {@link #sql(String)}. + * * @param stmt The SQL statement to evaluate. * @param config The {@link QueryConfig} to use. */ + @Deprecated Review comment: Yeah, the `QueryConfig` is only used by `SqlInsert` now, we need clear definition for this config if we add it into the `sql()`, at this stage, we can deprecate the `sqlUpdate(config)` and only add `sql()` for a start up. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services