[
https://issues.apache.org/jira/browse/FLINK-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900330#comment-14900330
]
ASF GitHub Bot commented on FLINK-2649:
---------------------------------------
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1151#issuecomment-141899978
LGTM
> Potential resource leak in JarHelper#unjar()
> --------------------------------------------
>
> Key: FLINK-2649
> URL: https://issues.apache.org/jira/browse/FLINK-2649
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
>
> {code}
> dest = new BufferedOutputStream(fos, BUFFER_SIZE);
> while ((count = jis.read(data, 0, BUFFER_SIZE)) != -1) {
> dest.write(data, 0, count);
> }
> dest.flush();
> dest.close();
> {code}
> The close() of dest should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
