Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1157#discussion_r39972364
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyContext.java
---
@@ -53,6 +58,10 @@ public FlinkTopologyContext(final StormTopology
topology, final Map<Integer, Str
null, null);
}
+ public void setContext(final StreamingRuntimeContext context) {
--- End diff --
I would extend the constructor instead of `setContext`. Using the
constructor is less error prone because it forced to provide the
`RuntimeContext`. An additional call to `setContext` could be "forgotten" by a
programmer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
