Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-142107041
Actually, I think the tests are okay. The triggers are part of some tests
only, because this is a unit test that checks many features independently.
- There are two tests that validate behavior of triggers (regular case
and exception case). Both hang with out a trigger.
- Many tests test parameterization, timestamp alignments, and scheduling.
They need no triggers or mock triggers, so those naturally run without proper
triggers.
- Some test define corner conditions around windowing / closing. These
are valid even if everything happens in close(), so they are correct as well.
- Some tests check pure closing behavior (emit trailing data, make sure
exceptions are propagated)
I will add another test that checks the correct operation of tumbling
window triggers, but aside from that, I think the test coverage is good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
