godfreyhe commented on a change in pull request #9035: [FLINK-13168] [table] clarify isBatch/isStreaming/isBounded flag in flink planner and blink planner URL: https://github.com/apache/flink/pull/9035#discussion_r302816538
########## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/util/TableTestBase.scala ########## @@ -810,13 +811,10 @@ case class JavaBatchTableTestUtil(test: TableTestBase) extends JavaTableTestUtil /** * Batch/Stream [[org.apache.flink.table.sources.TableSource]] for testing. */ -class TestTableSource(isBatch: Boolean, schema: TableSchema) +class TestTableSource(val isBounded: Boolean, schema: TableSchema) Review comment: bounded `TestTableSource` will also used in streaming test, so i think isBounded is more suitable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
