Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-142331659
I think the implementation of `stopExecution()` is fine. You are executing
the call in a separate thread and you are logging exceptions. A blocking stop()
method implemented by a user would not block the actor.
I would catch `Throwable` instead of `RuntimeException`, just to ensure
that really no exception is thrown out of the thread.
This PR is touching very critical components of Flink. I would really
appreciate a review by @tillrohrmann and @StephanEwen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
