twalthr commented on a change in pull request #8920: [FLINK-13024][table]
integrate FunctionCatalog with CatalogManager
URL: https://github.com/apache/flink/pull/8920#discussion_r303427130
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableFactory.java
##########
@@ -112,4 +141,75 @@ public HiveTableFactory(HiveConf hiveConf) {
return new HiveTableSink(new JobConf(hiveConf), tablePath,
table);
}
+ @Override
+ public FunctionDefinition createFunctionDefinition(String name,
CatalogFunction catalogFunction) {
Review comment:
Actually, a factory does not need to know the name. `ObjectPath` in
`createTableSource/Sink()` is only a temporary solution, right? If we want to
pass it for debugging purposes we should pass the entire `ObjectIdentifier`.
But I would prefer a clean signature `createXXX(CatalogXXX)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
