GJL commented on a change in pull request #9113: [FLINK-13222] [runtime] Add 
documentation for failover strategy option
URL: https://github.com/apache/flink/pull/9113#discussion_r305271732
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
 ##########
 @@ -105,18 +105,27 @@
 
        /**
         * This option specifies the failover strategy, i.e. how the job 
computation recovers from task failures.
+        * The option "individual" and "region-legacy" are intentionally not 
included
+        * as they have some known limitations or issues.
+        * "individual" strategy only works when all tasks are not connected, 
in which case the "region"
+        * failover strategy would also restart failed tasks individually.
+        * "region-legacy" strategy is not able to backtrack missing input 
result partitions.
+        * The new "region" strategy supersedes "individual" and 
"region-legacy" strategies and should always work.
         */
-       @Documentation.ExcludeFromDocumentation("The failover strategy feature 
is highly experimental.")
        public static final ConfigOption<String> EXECUTION_FAILOVER_STRATEGY =
                key("jobmanager.execution.failover-strategy")
                        .defaultValue("full")
                        .withDescription(Description.builder()
                                .text("This option specifies how the job 
computation recovers from task failures. " +
                                        "Accepted values are:")
                                .list(
-                                       text("'full': Restarts all tasks."),
-                                       text("'individual': Restarts only the 
failed task. Should only be used if all tasks are independent components."),
-                                       text("'region': Restarts all tasks that 
could be affected by the task failure.")
+                                       text("'full': Restarts all tasks to 
recover the job."),
+                                       text("'region': Restarts all tasks that 
could be affected by the task failure. " +
 
 Review comment:
   Maybe we can omit some details here, and place a hyperlink to the *Task 
Failure Recovery* page using `LinkElement`. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to