[ 
https://issues.apache.org/jira/browse/FLINK-12595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889565#comment-16889565
 ] 

Shannon Carey edited comment on FLINK-12595 at 7/20/19 6:26 PM:
----------------------------------------------------------------

Another thing I noticed: FlinkKinesisConsumer#sourceContext.close() is not 
called if fetcher.runFetcher() throws an exception. This seems like it might be 
a problem? Should that be moved into a "finally" block? Do you think I should 
submit a separate issue for that?


was (Author: rehevkor5):
Another thing I noticed: FlinkKinesisConsumer#sourceContext.close() is not 
called if fetcher.runFetcher() throws an exception. This seems like it might be 
a problem? Should that be moved into a "finally" block? Do you think I should 
submit a separate issue for that??

> KinesisDataFetcherTest.testOriginalExceptionIsPreservedWhenInterruptedDuringShutdown
>  deadlocks
> ----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-12595
>                 URL: https://issues.apache.org/jira/browse/FLINK-12595
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Kinesis, Tests
>    Affects Versions: 1.9.0
>            Reporter: Dawid Wysakowicz
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.9.0
>
>
> https://api.travis-ci.org/v3/job/535738122/log.txt



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to