liyafan82 commented on a change in pull request #9101: [FLINK-13221][Table SQL
/ Planner] Blink planner should set ScheduleMode to
LAZY_FROM_SOURCES_WITH_BATCH_SLOT_REQUEST for batch jobs
URL: https://github.com/apache/flink/pull/9101#discussion_r305659842
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
##########
@@ -593,12 +593,19 @@ public void testDefaultScheduleMode() {
public void testSetScheduleMode() {
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
- StreamGraph streamGraph = new
StreamGraphGenerator(Collections.emptyList(),
+ StreamGraph streamGraph1 = new
StreamGraphGenerator(Collections.emptyList(),
env.getConfig(), env.getCheckpointConfig())
.setScheduleMode(ScheduleMode.LAZY_FROM_SOURCES)
.generate();
- JobGraph jobGraph =
StreamingJobGraphGenerator.createJobGraph(streamGraph);
- assertEquals(ScheduleMode.LAZY_FROM_SOURCES,
jobGraph.getScheduleMode());
+ JobGraph jobGraph1 =
StreamingJobGraphGenerator.createJobGraph(streamGraph1);
+ assertEquals(ScheduleMode.LAZY_FROM_SOURCES,
jobGraph1.getScheduleMode());
+
+ StreamGraph streamGraph2 = new
StreamGraphGenerator(Collections.emptyList(),
+ env.getConfig(), env.getCheckpointConfig())
+
.setScheduleMode(ScheduleMode.LAZY_FROM_SOURCES_WITH_BATCH_SLOT_REQUEST)
Review comment:
Reverted. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
