JingsongLi commented on issue #9180: [FLINK-13331][table-planner-blink] Add 
CachedMiniCluster to share cluster between ITCases
URL: https://github.com/apache/flink/pull/9180#issuecomment-513625785
 
 
   @wuchong @zentol Thanks for your attention. 
   
   About leak resources, there is a clean thread to invoke 
`MiniClusterWithClientResource.after` to clean resources. Compared with the 
past, it only delayed cleaning up resources by 15 seconds.
   
   >I have doubts whether this will improve the test times in a significant 
way, since we're only skipping the creation of ~60 mini clusters.
   
   Yeah, we should gauge how valuable this change is.
   1.I test on my macbook pro, blink-planner will use 17min before, and use 
11min now for `mvn clean verify`. If we just run `mvn verify`, the gap will be 
more pronounced.
   2.But the more accurate test time should be travis triggering, I will update 
later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to