[
https://issues.apache.org/jira/browse/FLINK-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906196#comment-14906196
]
ASF GitHub Bot commented on FLINK-2751:
---------------------------------------
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-142895387
Hi @rerngvit, I have tested your pull request.
Because `setup_quickstart.html` contains "setup" keyword in url, there are
two active menus (Quickstart, Setup) when we open Quickstart: Setup page. I
found a solution like following:
```html
<li class="dropdown{% if page.url contains '/quickstart/' %} active{% endif
%}">
```
The solution must be applied not only quickstart but also other dropdown
menus such as setup, programming guide, ..., etc..
BTW, there is a typo line 68 of `navbar.html`. A tag must be closed. I know
this is not related your changes but fixing it would be better.
After addressing this, we can merge this pull request. :-)
> Quickstart is in documentation but only linked through the Flink homepage
> -------------------------------------------------------------------------
>
> Key: FLINK-2751
> URL: https://issues.apache.org/jira/browse/FLINK-2751
> Project: Flink
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 0.9, 0.10
> Reporter: Maximilian Michels
> Labels: starter
> Fix For: 0.9, 0.10
>
>
> The Quickstart docs contained in {{docs/quickstart}} should also be included
> in the documentation menu. Basically, we could copy over the Quickstart menu
> from the Flink homepage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
