[ 
https://issues.apache.org/jira/browse/FLINK-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906385#comment-14906385
 ] 

ASF GitHub Bot commented on FLINK-2753:
---------------------------------------

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1175#issuecomment-142940983
  
    @StephanEwen  How attached are you to your Generic Type names? Because in 
the current code base we have single character uppercase style (T, E, V, C and 
so on, as is the sun/oracle style) and multi character uppercase style (OUT, 
KEY). Now you introduced a third style in some of your new classes. Here the 
generic parameters have the same naming convention as class names.
    
    I think we have to standardize a bit here. :smile: 


> Add new window API to streaming API
> -----------------------------------
>
>                 Key: FLINK-2753
>                 URL: https://issues.apache.org/jira/browse/FLINK-2753
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming
>    Affects Versions: 0.10
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>             Fix For: 0.10
>
>
> The API integration should follow the API design as documented here:
> https://cwiki.apache.org/confluence/display/FLINK/Streams+and+Operations+on+Streams
> This issue needs:
>   - Add new {{KeyedWindowDataStream}}, created by calling{{window()}} on the 
> {{KeyedDataStream}}.
>   - Add a utility that converts Window Policies into concrete window 
> implementations. This is important to realize special case implementations 
> that do not directly use generic mechanisms implemented by window policies.
>   - Instantiating the operators (dedicated and generic) from the window 
> policies
>   - I will add a stub for the new Window Policy classes, based on the 
> existing policy classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to