[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906501#comment-14906501 ]
ASF GitHub Bot commented on FLINK-2111: --------------------------------------- Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r40333103 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -588,15 +653,16 @@ protected int cancel(String[] args) { ActorGateway jobManager = getJobManagerGateway(options); Future<Object> response = jobManager.ask(new CancelJob(jobId), askTimeout); - try { - Await.result(response, askTimeout); - return 0; - } - catch (Exception e) { - throw new Exception("Canceling the job with ID " + jobId + " failed.", e); + Object rc = Await.result(response, askTimeout); + + if (rc instanceof CancellationFailure) { --- End diff -- See above > Add "stop" signal to cleanly shutdown streaming jobs > ---------------------------------------------------- > > Key: FLINK-2111 > URL: https://issues.apache.org/jira/browse/FLINK-2111 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, JobManager, Local Runtime, > Streaming, TaskManager, Webfrontend > Reporter: Matthias J. Sax > Assignee: Matthias J. Sax > Priority: Minor > > Currently, streaming jobs can only be stopped using "cancel" command, what is > a "hard" stop with no clean shutdown. > The new introduced "stop" signal, will only affect streaming source tasks > such that the sources can stop emitting data and shutdown cleanly, resulting > in a clean shutdown of the whole streaming job. > This feature is a pre-requirment for > https://issues.apache.org/jira/browse/FLINK-1929 -- This message was sent by Atlassian JIRA (v6.3.4#6332)