NicoK commented on a change in pull request #9132: [FLINK-13245][network] Fix
the bug of file resource leak while canceling partition request
URL: https://github.com/apache/flink/pull/9132#discussion_r306718179
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -308,14 +305,22 @@ private void handleException(Channel channel, Throwable
cause) throws IOExceptio
private void releaseAllResources() throws IOException {
// note: this is only ever executed by one thread: the Netty IO
thread!
for (NetworkSequenceViewReader reader : allReaders.values()) {
- reader.releaseAllResources();
- markAsReleased(reader.getReceiverId());
+ releaseViewReader(reader, false);
}
availableReaders.clear();
allReaders.clear();
}
+ private void releaseViewReader(NetworkSequenceViewReader reader,
boolean shouldNotifyConsumed) throws IOException {
Review comment:
nit: please break this line apart (too long)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
