xintongsong commented on issue #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance. URL: https://github.com/apache/flink/pull/9105#issuecomment-515436016 @tillrohrmann I've addressed the comments and updated the PR. Also rebased to the latest release-1.9 branch resolving the new conflicts. Below is a brief change log. - 3b20ed5c8684466d59220d13019b5f481c78a3cd..8369fc5c36adeb4a27b0c83653190de4278dbc90: These are the original commits of fixing the problem for setting wrong configuration instance. - Then I reverted the rest of the commits that move `updateTaskManagerConfigAndCreateWorkerSlotProfiles()` and `testCreateSlotsPerWorker()` to `ResourceManager` and `ResourceManagerTest` respectively. - a31e73a347e357c1a6fedcd1bad322302848d680: Introduce `taskManagerConfig` and `slotResourceProfile` and the computing of slot resource profile in `ContaineredTaskManagerParameters`. - 1395bd7a7ac7a8e9e6801685415337a0d6edec71: Use `ContaineredTaskManagerParameters` to compute and record default configs and slot resource profiles of task managers in Yarn / Mesos. - 779d3038af44c64cdb3b30fe40e9ddff88116ffd..70d2ed3eebc9874eb70559fc5a72b5366392b0df: Test updates. The PR has already passed the travis test. https://travis-ci.org/xintongsong/flink/builds/563897220
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services