tillrohrmann commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r307806934
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -184,7 +183,9 @@ public YarnResourceManager(
this.defaultCpus =
flinkConfig.getInteger(YarnConfigOptions.VCORES, numberOfTaskSlots);
this.resource =
Resource.newInstance(defaultTaskManagerMemoryMB, defaultCpus);
- this.slotsPerWorker =
updateTaskManagerConfigAndCreateWorkerSlotProfiles(flinkConfig,
defaultTaskManagerMemoryMB, numberOfTaskSlots);
+ this.defaultTaskManagerParameters =
ContaineredTaskManagerParameters.create(flinkConfig,
defaultTaskManagerMemoryMB, numberOfTaskSlots);
+ this.flinkConfig =
defaultTaskManagerParameters.getTaskManagerConfig();
Review comment:
The only reason for the `flinkConfig` is the call
`HistoryServerUtils.getHistoryServerURL` for which we need a Flink
configuration. We could create a follow up issue to pass in a
`HistoryServerConfiguration` instead which contains all configuration values.
That way, we could get rid of having to pass in a `Configuration` object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
