Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/593#discussion_r40493024
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
@@ -51,12 +50,25 @@ public void testJobWithCustomInputFormat() {
PackagedProgram inputSplitTestProg = new
PackagedProgram(new File(INPUT_SPLITS_PROG_JAR_FILE),
new String[] {
INPUT_SPLITS_PROG_JAR_FILE,
+
"", // classpath
"localhost",
String.valueOf(port),
"4" // parallelism
} );
inputSplitTestProg.invokeInteractiveModeForExecution();
+
+
+ String classpath = new
File(INPUT_SPLITS_PROG_JAR_FILE).toURI().toURL().toString();
+ PackagedProgram inputSplitTestProg2 = new
PackagedProgram(new File(INPUT_SPLITS_PROG_JAR_FILE),
+ new String[] { "",
+
classpath, // classpath
+
"localhost",
+
String.valueOf(port),
+
"4" // parallelism
+ } );
+
inputSplitTestProg2.invokeInteractiveModeForExecution();
+
--- End diff --
Looks like I wrote this comment before testing the functionality ;) It
seems that the test does not detect the issues I found with manual testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
