JingsongLi commented on a change in pull request #9275: 
[FLINK-13290][table-planner-blink][hbase] SinkCodeGenerator should not compare 
row type field names and enable blink planner for hbase IT case
URL: https://github.com/apache/flink/pull/9275#discussion_r308674621
 
 

 ##########
 File path: 
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/HBaseSinkITCase.java
 ##########
 @@ -52,9 +55,13 @@
 /**
  * IT case Test for {@link HBaseUpsertTableSink}.
  */
+@RunWith(Parameterized.class)
 public class HBaseSinkITCase extends HBaseTestingClusterAutostarter {
        private static final long serialVersionUID = 1L;
 
+       private static final String BLINK_PLANNER = "Blink";
 
 Review comment:
   use enum instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to