zjuwangg commented on a change in pull request #9239: [FLINK-13385]Align Hive 
data type mapping with FLIP-37
URL: https://github.com/apache/flink/pull/9239#discussion_r309935735
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTypeUtil.java
 ##########
 @@ -85,65 +86,71 @@ public static TypeInfo toHiveTypeInfo(DataType dataType) {
                LogicalTypeRoot type = dataType.getLogicalType().getTypeRoot();
 
                if (dataType instanceof AtomicDataType) {
 
 Review comment:
   Yep, that would be more elegant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to