JingsongLi commented on a change in pull request #9322: [FLINK-13471][table]
Add FlatAggregate support to stream Table API(blink planner)
URL: https://github.com/apache/flink/pull/9322#discussion_r310100150
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/RelExplainUtil.scala
##########
@@ -329,11 +329,16 @@ object RelExplainUtil {
stringifyAggregates(aggInfos, distinctAggs, aggFilters, inFieldNames)
}
+ val isTableAggregate =
+
AggregateUtil.isTableAggregate(aggInfoList.getActualAggregateCalls.toList)
val outputFieldNames = if (isLocal) {
grouping.map(inFieldNames(_)) ++ localAggOutputFieldNames(aggOffset,
aggInfos, outFieldNames)
} else if (isIncremental) {
val accFieldNames = inputRowType.getFieldNames.toList.toArray
grouping.map(inFieldNames(_)) ++ localAggOutputFieldNames(aggOffset,
aggInfos, accFieldNames)
+ } else if (isTableAggregate) {
+ outFieldNames.toList.subList(0, grouping.length).toArray ++
Review comment:
just use `outFieldNames.slice(0, grouping.length)` or dropRight?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
