dawidwys commented on a change in pull request #9334:
[FLINK-10257][FLINK-13463][table] Support VARCHAR type generalization
consistently
URL: https://github.com/apache/flink/pull/9334#discussion_r310096542
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/ValuesITCase.scala
##########
@@ -33,17 +32,18 @@ class ValuesITCase extends StreamingTestBase {
@Test
def testValues(): Unit = {
- val sqlQuery = "SELECT * FROM (VALUES (1, 2, 3)) T(a, b, c)"
+ val sqlQuery = "SELECT * FROM (VALUES (1, 'Bob'), (1, 'Alice')) T(a, b)"
- val outputType = new BaseRowTypeInfo(new IntType(), new IntType(), new
IntType())
+ val outputType = new BaseRowTypeInfo(
+ new IntType(),
+ new VarCharType(VarCharType.MAX_LENGTH))
Review comment:
Can't we specify the correct precision already. It should not make a
difference for now (as the precision is lost when converting to
`TypeInformation`), but in the long term I think it should be `new
VarCharType(5)`, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
