[GitHub] [flink] TsReaper commented on a change in pull request #9328: [FLINK-13521][sql-client] Allow setting configurations in SQL CLI

[GitBox]

TsReaper commented on a change in pull request #9328: [FLINK-13521][sql-client] 
Allow setting configurations in SQL CLI
URL: https://github.com/apache/flink/pull/9328#discussion_r310163237
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
 ##########
 @@ -212,6 +226,9 @@ public static Environment merge(Environment env1, 
Environment env2) {
                // merge deployment properties
                mergedEnv.deployment = 
DeploymentEntry.merge(env1.getDeployment(), env2.getDeployment());
 
+               // merge execution properties
 
 Review comment:
   
![got-it](https://github.com/TsReaper/stickers/blob/master/stickers/eastern-timber-wolf/got-it.jpg?raw=true)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services