carp84 opened a new pull request #9364: [FLINK-13593][checkpointing] Prevent failing the wrong job in CheckpointFailureManager URL: https://github.com/apache/flink/pull/9364 ## What is the purpose of the change This PR fixes the issue as reported in FLINK_13593, that due to the asynchronously handling of checkpoint decline message in `LegacyScheduler#declineCheckpoint`, it's possible that the message is handled before job status transition thus `receiveDeclineMessage` grabbed the lock in `CheckpointCoordinator` before `pendingCheckpoints` got cleared by `stopCheckpointScheduler` (as triggered by the job status listener `CheckpointCoordinatorDeActivator`). If the job/tasks restarts quickly enough, the FailJobCallback in CheckpointFailureManager might unexpectedly fail the job again. ## Brief change log Add a safe guard when failing the job, passing through the `ExecutionAttemptID` and checking against the current executions to make sure the to-be-failed one is still running, so we won't fail the newly restarted one by accident. ## Verifying this change The issue is revealed by the unstable failure of `KafkaProducerExactlyOnceITCase` thus is already covered by existing tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
