TsReaper commented on a change in pull request #9342: [FLINK-13438][hive] Fix
DataTypes.DATE/TIME/TIMESTAMP support for hive connectors
URL: https://github.com/apache/flink/pull/9342#discussion_r310897029
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java
##########
@@ -74,10 +76,13 @@
public HiveTableSink(JobConf jobConf, ObjectPath tablePath,
CatalogTable table) {
this.jobConf = jobConf;
this.tablePath = tablePath;
- this.catalogTable = table;
+
+ Preconditions.checkArgument(table instanceof CatalogTableImpl);
+ this.catalogTable = HiveTableUtil.toHiveCatalogTable(table);
Review comment:
You're right. But `CatalogTableImpl` currently does not have setSchema
method. Should I add one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
