docete commented on a change in pull request #9331:
[FLINK-13523][table-planner-blink] Verify and correct arithmetic function's
semantic for Blink planner
URL: https://github.com/apache/flink/pull/9331#discussion_r311827465
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/agg/DeclarativeAggCodeGen.scala
##########
@@ -204,8 +204,13 @@ class DeclarativeAggCodeGen(
}
def getValue(generator: ExprCodeGenerator): GeneratedExpression = {
- val resolvedGetValueExpression = function.getValueExpression
+ val expr = function.getValueExpression
.accept(ResolveReference())
+ val resolvedGetValueExpression = ApiExpressionUtils.unresolvedCall(
Review comment:
Yes, but there is no guarantee about this. So I think add a cast there is
more safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
