wuchong commented on a change in pull request #9377:
[FLINK-13561][table-planner-blink] Verify and correct time function's semantic
for Blink planner
URL: https://github.com/apache/flink/pull/9377#discussion_r311839539
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGeneratorContext.scala
##########
@@ -518,17 +518,6 @@ class CodeGeneratorContext(val tableConfig: TableConfig) {
DEFAULT_TIMEZONE_TERM
}
- /**
- * Adds a reusable Time ZoneId to the member area of the generated class.
- */
- def addReusableTimeZoneID(): String = {
Review comment:
I would like to remove dead code and introduce them when we need them.
Furthermore, these code does't work, for example, it uses the same member field
name with timeZone, it doesn't add code to member area.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
