wuchong commented on a change in pull request #9335: [FLINK-13503][API] Add
contract in `LookupableTableSource` to specify the behavior when lookupKeys
contains null.
URL: https://github.com/apache/flink/pull/9335#discussion_r311842402
##########
File path:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/util/HBaseReadWriteHelper.java
##########
@@ -86,17 +86,27 @@ public HBaseReadWriteHelper(HBaseTableSchema
hbaseTableSchema) {
this.resultRow = new Row(fieldLength);
}
+ /**
+ * Serializes a rowkey object into byte array.
+ * @param rowKey rowkey object to serialize
+ *
+ * @return serialize bytes.
+ */
+ public byte[] serialize(Object rowKey) {
+ byte[] key = HBaseTypeUtils.serializeFromObject(
+ rowKey,
+ rowKeyType,
+ charset);
+ return key;
+ }
+
/**
* Returns an instance of Get that retrieves the matches records from
the HBase table.
*
* @return The appropriate instance of Get for this use case.
*/
- public Get createGet(Object rowKey) {
- byte[] rowkey = HBaseTypeUtils.serializeFromObject(
- rowKey,
- rowKeyType,
- charset);
- Get get = new Get(rowkey);
+ public Get createGet(byte[] row) {
Review comment:
`row` -> `rowkey`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
