zhijiangW opened a new pull request #9475: [FLINK-13762][task] Implement a unified StatusWatermarkOutputHandler for StreamOne/TwoInputProcessor URL: https://github.com/apache/flink/pull/9475 ## What is the purpose of the change Currently `StreamOneInputProcessor` and `StreamTwoInputSelectableProcessor` have separate implementations of `ForwardingValveOutputHandler`. Especially for the implementation in `StreamTwoInputSelectableProcessor`, it couples the internal input index logic which would be a blocker for the following unification of `StreamTaskInput/Output`. We could refactor the implementation of `StreamStatusMaintainer` for judging the status of different inputs internally before really emitting the `StreamStatus`. So it is reasonable to realize a unified `ForwardingValveOutputHandler` for both `StreamOneInput/ TwoInputSelectableProcessor`, and it does not consider different inputs to always propogate `StreamStatus`. ## Brief change log - *Adjust `StreamStatusMaintainerImpl` to emit idle status only if all input status are idle.* - *Refactor the class name for `StatusWatermarkValue` and `ValueOutputHandler`* - *Implement a unified `ForwardingStatusWatermarkOutputHandler` for both one/two input processors* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services