zhijiangW opened a new pull request #9476: [FLINK-13764][task, metrics] Pass the counter of numRecordsIn into the constructors of StreamOne/TwoInputProcessor URL: https://github.com/apache/flink/pull/9476 ## What is the purpose of the change Currently the counter of `numRecordsIn` is setup while processing input in processor. In order to integrate the processing logic based on `StreamTaskInput#emitNext(Output)` later, we need to pass the counter into output functions then. So this refactoring is the precondition of following works, and it could get additional benefits. One is that we could make the counter as final field in `StreamInputProcessor`. Another is that we could reuse the counter setup logic for both `StreamOne/TwoInputProcessors`. There should be no side effects if we make the counter setup a bit earlier than the previous way. ## Brief change log - *Introduce the method of setup `numRecordsIn` counter in `StreamTask`* - *Pass the counter into the constructors of `StreamOne/TwoInputProcessors`* - *Remove the logic of initializing counter in `StreamOne/TwoInputProcessors`* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
