1u0 commented on a change in pull request #9470: [FLINK-13380][k8s] Improve the 
usability of Flink session cluster on Kubernetes
URL: https://github.com/apache/flink/pull/9470#discussion_r315590339
 
 

 ##########
 File path: docs/ops/deployment/kubernetes.md
 ##########
 @@ -166,18 +249,34 @@ kind: Service
 metadata:
   name: flink-jobmanager
 spec:
+  type: ClusterIP
   ports:
   - name: rpc
     port: 6123
   - name: blob
     port: 6124
-  - name: query
-    port: 6125
   - name: ui
     port: 8081
   selector:
     app: flink
     component: jobmanager
 {% endhighlight %}
 
+`jobmanager-rest-service.yaml`. Optional service, which is used to add a 
`NodePort` on the jobmanager rest service so that user could submit job via 
`<public-node-ip>:<node-port>`.
 
 Review comment:
   Can be rephrased to smt. like:
   ```
   Optional service, that exposes the jobmanager `ui` port as public Kubernetes 
node's port.
   ```
   
   But personally, I'd avoid adding this at all, as poor 
recommendation/guidance for users (as mentioned before).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to