JingsongLi commented on a change in pull request #9484: [FLINK-13774][table]
Expression DSL use should resolve Expressions in blink
URL: https://github.com/apache/flink/pull/9484#discussion_r315594066
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/PushFilterIntoTableSourceScanRule.scala
##########
@@ -112,8 +112,8 @@ class PushFilterIntoTableSourceScanRule extends RelOptRule(
call.transformTo(newScan)
} else {
relBuilder.push(scan)
- val converter = new RexNodeConverter(relBuilder)
Review comment:
One question is whether `UnsolvedExpression` or `ResolvedExpression` is
passed to `FilterableTableSource`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
