[ 
https://issues.apache.org/jira/browse/FLINK-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916469#comment-16916469
 ] 

Kostas Kloudas commented on FLINK-13864:
----------------------------------------

Hi [~kailashhd]!

Could you please be more specific about:

1) what is the functionality you want to add?

2) which parts need to be adjusted so that the {{StreamingFileSink}} is more 
"friendly" for extension (after the merging of the PRs you pointed to)?

In the PR you post in the mailing-list thread, you make all the members of the 
FormatBuilders protected and all the factory interfaces public. Is this 
necessary? Giving a bit more details about what you need can help us also 
figure out the context under which to review your PR ;)

> StreamingFileSink: Allow inherited classes to extend StreamingFileSink 
> correctly
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-13864
>                 URL: https://issues.apache.org/jira/browse/FLINK-13864
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / FileSystem
>            Reporter: Kailash Hassan Dayanand
>            Priority: Minor
>
> Currently the StreamingFileSink can't be extended correctly as there are a 
> few issues [PR |[https://github.com/apache/flink/pull/8469]] merged for  this 
> [Jira|https://issues.apache.org/jira/browse/FLINK-12539]
> Mailing list discussion: 
> [http://mail-archives.apache.org/mod_mbox/flink-dev/201908.mbox/%3CCACGLQUAxXjr2mBOf-6hbXcwmWoH5ib_0YEy-Vyjj%3DEPyQ25Qiw%40mail.gmail.com%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to