carp84 commented on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-525626160 Thanks for the review @StephanEwen @tillrohrmann ! I've addressed most of the comments and left some questions open. For the Unsafe helper, since merging it into `MemoryUtils` now will cause quite some code refactor, how about we move the `UnsafeHelp` and `ByteBufferUtils` into `flink-core` module under `org.apache.flink.core.memory` package first, and then align all Unsafe/VarHandle in another PR? Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
