pnowojski commented on a change in pull request #9564:
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319468648
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -380,9 +380,6 @@ public final void invoke() throws Exception {
// -------- Invoke --------
Review comment:
Can we re-order the commits, that all of the refactors/preparations commits
like:
- open mailbox early
- drain mailbox
- "Move decline checkpoint handling into StreamTask"
- ...
Come before the `AsyncWaitOperator` and `Timers`? In that case we would have
only a sequence of 3 hard linked commits (AsyncWaitOperator, timers,
checkpoints), instead of 8? 9? What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
