Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1153#issuecomment-145557954
Thanks for taking the time to review. Thanks for the great renaming
suggestions and all the other more subtle remarks. I agree with virtually all
comments.
The only thing, which needs some clarification is regarding the checkpoint
ID counter. What's your take on my inline comment? To recap: I'm not sure
whether the second point really makes it easier, because we would have to add
the retry logic to all the operations manually. Currently, Curator takes care
of this for us. Do you think it's a good idea to merge it into the
CompletedCheckpointStore?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
