TisonKun commented on a change in pull request #9609: 
[FLINK-13750][client][coordination] Separate HA services between client-side 
and server-side
URL: https://github.com/apache/flink/pull/9609#discussion_r320690501
 
 

 ##########
 File path: 
flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java
 ##########
 @@ -157,15 +154,20 @@ public String stopWithSavepoint(JobID jobId, boolean 
advanceToEndOfEventTime, @N
                return MiniClusterId.INSTANCE;
        }
 
-       // ======================================
-       // Legacy methods
-       // ======================================
-
        @Override
        public String getWebInterfaceURL() {
                return miniCluster.getRestAddress().toString();
        }
 
+       @Override
+       public void shutDownCluster() {
+               try {
+                       miniCluster.close();
+               } catch (Exception e) {
+                       ExceptionUtils.rethrow(e);
+               }
+       }
 
 Review comment:
   Reverted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to