AHeise commented on a change in pull request #9483: [FLINK-13767][task] Migrate
isFinished method from AvailabilityListener to AsyncDataInput
URL: https://github.com/apache/flink/pull/9483#discussion_r320741075
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/AvailabilityListener.java
##########
@@ -33,11 +33,6 @@
*/
CompletableFuture<?> AVAILABLE =
CompletableFuture.completedFuture(null);
- /**
Review comment:
Not sure if this is relevant to this PR, but isn't `AvailabilityListener` a
misnomer? I'd expect a listener to be the one to be notified and not the one to
notify. I also only know listeners as callbacks.
Implementators of this interface would rather be `AvailabilityReporter` or
`AvailabilityProvider`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
