[ 
https://issues.apache.org/jira/browse/FLINK-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944689#comment-14944689
 ] 

ASF GitHub Bot commented on FLINK-2818:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1224#issuecomment-145781279
  
    Looks good, +1 to merge
    
    BTW: I think its not necessary to {@link} the return types - they are 
linked anyways in the JavaDoc.


> The *ReduceDriver classes have incorrect javadocs
> -------------------------------------------------
>
>                 Key: FLINK-2818
>                 URL: https://issues.apache.org/jira/browse/FLINK-2818
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Runtime
>            Reporter: Gabor Gevay
>            Assignee: Gabor Gevay
>            Priority: Trivial
>
> The javadocs of ReduceDriver, AllReduceDriver, AllGroupReduceDriver, 
> GroupReduceDriver, GroupReduceCombineDriver, and GroupCombineChainedDriver 
> are outdated and/or copy-pasted-then-not-correctly-modified, which makes 
> deciphering what all these classes are more difficult.
> PR coming shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to