AHeise commented on a change in pull request #7942: [FLINK-11696][checkpoint]
Avoid to send mkdir requests to DFS from task side
URL: https://github.com/apache/flink/pull/7942#discussion_r322592518
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStorage.java
##########
@@ -107,6 +104,12 @@ public boolean supportsHighlyAvailableStorage() {
return true;
}
+ @Override
+ public void initializeBaseLocations() throws IOException {
+ fileSystem.mkdirs(sharedStateDirectory);
+ fileSystem.mkdirs(taskOwnedStateDirectory);
+ }
+
@Override
public CheckpointStorageLocation initializeLocationForCheckpoint(long
checkpointId) throws IOException {
checkArgument(checkpointId >= 0);
Review comment:
Should we verify that the base locations have been initialized? Some kind of
flag in `initializeBaseLocations()`?
The javadoc clearly states this contract, but it may help if we introduce a
bug later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
