zhuzhurk commented on a change in pull request #9663:
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r325660299
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1032,9 +1046,13 @@ void markFailed(Throwable t) {
}
void markFailed(Throwable t, Map<String, Accumulator<?, ?>>
userAccumulators, IOMetrics metrics) {
+ markFailed(t, userAccumulators, metrics, false);
+ }
+
+ void markFailed(Throwable t, Map<String, Accumulator<?, ?>>
userAccumulators, IOMetrics metrics, boolean fromSchedulerNg) {
// skip release of partitions since this is only called if the
TM actually sent the FAILED state update
Review comment:
The comments seem to be outdated.
With changes in this PR, the pre-assumption seems to break since the failure
bay be triggered internally from JM. Though it may not be problematic since the
errors originate from `processFail(Throwable t, boolean isCallback)` which will
trigger the partition to be released earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
