docete commented on a change in pull request #8706: [FLINK-12814][sql-client]
Support a traditional and scrolling view of…
URL: https://github.com/apache/flink/pull/8706#discussion_r325963126
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/entries/ExecutionEntry.java
##########
@@ -108,6 +108,10 @@
public static final String EXECUTION_CURRENT_DATABASE =
"current-database";
+ private static final String EXECUTION_INTERACTIVE_VIEW_ENABLED =
"interactive-view.enabled";
+
+ private static final String EXECUTION_MAX_QUERY_TIMEOUT_MS =
"max-query-timeout-ms";
Review comment:
It offers an overall protection for the user or downstream projects
submitting a long-running query(e.g., select * from kafakTable). IMO for DQL
cases in a streaming scenario, user always expects the result is
finalizable(He/She can not stare at the screen all of the day). For user, he
can use CTRL+C signal. For downstream project, a timeout should be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
