yxu-valleytider commented on a change in pull request #9581:
[FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to
allow for easier subclassing of StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#discussion_r326000120
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -264,37 +288,32 @@ private RowFormatBuilder(
subtaskIndex,
new PartFileConfig(partFilePrefix,
partFileSuffix));
}
-
- @VisibleForTesting
- StreamingFileSink.RowFormatBuilder<IN, BucketID>
withBucketFactory(final BucketFactory<IN, BucketID> factory) {
- return new RowFormatBuilder<>(basePath, encoder,
bucketAssigner, rollingPolicy, bucketCheckInterval,
Preconditions.checkNotNull(factory), partFilePrefix, partFileSuffix);
- }
}
/**
* A builder for configuring the sink for bulk-encoding formats, e.g.
Parquet/ORC.
*/
@PublicEvolving
- public static class BulkFormatBuilder<IN, BucketID> extends
StreamingFileSink.BucketsBuilder<IN, BucketID> {
+ public static class BulkFormatBuilder<IN, BucketID, T extends
BulkFormatBuilder<IN, BucketID, T>> extends
StreamingFileSink.BucketsBuilder<IN, BucketID, T> {
Review comment:
DONE similar changes as `RowFormatBuilder`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
