xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-533109547 > @xuyang1706 Thanks for the patch. I left some comments. In general it would avoid class name collision. We may also want to consider if the packaging can change a little bit. For example: > > ``` > org.apache.flink.ml. > .algooperator > .AlgoOperator.java > .stream > .StreamAlgoOperator.java > .source > .TableSourceStreamAlgoOperator.java > .batch > .BatchAlgoOperator.java > .source > TableSourceBatchAlgoOperator.java > ``` @becketqin , thanks for your advice. we defined MLEnvironmentFactory to replace the global static MLSession and support to set multiple Environment, refactored the class names and refined the javaDoc.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
