Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1211#discussion_r41389386
  
    --- Diff: 
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/ConnectedComponents.scala
 ---
    @@ -0,0 +1,121 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.graph.scala.example;
    +
    +import org.apache.flink.api.scala._
    +import org.apache.flink.graph.scala._
    +import org.apache.flink.graph.Edge
    +import org.apache.flink.types.NullValue
    +import org.apache.flink.graph.example.utils.ConnectedComponentsDefaultData
    +import org.apache.flink.api.common.functions.MapFunction
    +import org.apache.flink.graph.library.GSAConnectedComponents
    +import java.lang.Long
    +
    +/**
    + * This example shows how to use Gelly's library methods.
    + * You can find all available library methods in 
[[org.apache.flink.graph.library]]. 
    + * 
    + * In particular, this example uses the
    + * 
[[org.apache.flink.graph.library.ConnectedComponentsAlgorithm.GSAConnectedComponents]]
    + * library method to compute the connected components of the input graph.
    + *
    + * The input file is a plain text file and must be formatted as follows:
    + * Edges are represented by tuples of srcVertexId, trgVertexId which are
    + * separated by tabs. Edges themselves are separated by newlines.
    + * For example: <code>1\t2\n1\t3\n</code> defines two edges,
    + * 1-2 with and 1-3.
    + *
    + * Usage {{
    + *   ConnectedComponents <edge path> <result path> <number of iterations>
    + *   }}
    + * If no parameters are provided, the program is run with default data from
    + * [[org.apache.flink.graph.example.utils.ConnectedComponentsDefaultData]]
    + */
    +object ConnectedComponents {
    +  def main(args: Array[String]) {
    +    if (!parseParameters(args)) {
    +      return
    +      }
    --- End diff --
    
    The indention of the closing bracket is not in sync with Flink's remaining 
Scala code. It should on the same level as the opening statement, `if 
(!!parseParameters(args)) {` in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to